Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional constructor to OracleContainer #734

Merged
merged 5 commits into from
Jun 12, 2018
Merged

Add additional constructor to OracleContainer #734

merged 5 commits into from
Jun 12, 2018

Conversation

rwiskerke
Copy link
Contributor

This makes it possible to use an container based on a Dockerfile instead of a published image

@rnorth
Copy link
Member

rnorth commented Jun 10, 2018

@rwiskerke thanks - this looks like a good idea given the need to 'bring your own' Oracle images.

Thank you for the contribution!

Would you mind adding a changelog entry, then I think we're good to go. Thanks.

Copy link
Member

@rnorth rnorth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add changelog entry

@bsideup
Copy link
Member

bsideup commented Jun 10, 2018

@rnorth aren't we agreed to add it ourselves?

@rwiskerke
Copy link
Contributor Author

@rnorth @bsideup Added the change to the changelog, but feel free to edit the entry if you like.

@kiview
Copy link
Member

kiview commented Jun 12, 2018

@rwiskerke Thanks a lot, I made a slight change to the wording 😉

@kiview kiview merged commit 2affee9 into testcontainers:master Jun 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants