Make JdbcDatabaseContainer#getDriverClassName public #743
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are use cases which require configuring the actual JDBC
driverClassName
onDataSource
pool implementation. One such example that I ran into recently is using a HikariCP pool with MySQL 8 Testcontainer (related #736).This PR changes the visibility of
JdbcDatabaseContainer#getDriverClassName
method topublic
. With this change, thedriverClassName
of the container can be reused when configuring theDataSource
, rather than having to manually specify it.There's an additional commit that adds a test to demonstrate the described problem - without setting
driverClassName
onHikariConfig
this test fails (due to wrong driver being used implicitly) with the following stacktrace: