Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shutdownHook to send sigterm to ryuk #7717

Merged
merged 1 commit into from
Oct 27, 2023
Merged

Conversation

eddumelendez
Copy link
Member

@eddumelendez eddumelendez commented Oct 24, 2023

Currently, Ryuk container finishes after around 10s. This commit register
a shutdown hook which will send a sigterm to the Ryuk container when JVM
is terminating causing Ryuk to finish sooner (hence cleaning up all resources that weren't yet removed directly).

Currently, `Ryuk` container finishes after around 10s. This commit register
a shutdown hook which will send a sigterm to the Ryuk container when JVM
is terminating causing Ryuk to finish sooner.
@eddumelendez eddumelendez requested a review from a team as a code owner October 24, 2023 18:16
Copy link
Member

@bsideup bsideup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@bsideup
Copy link
Member

bsideup commented Oct 26, 2023

Let's test this e2e, to ensure that the client is not closed by the time the hook is executed

@thristov4043
Copy link

This should be reverted since it is causing issues in Spring projects.

@pstetsuk-exadel
Copy link

pstetsuk-exadel commented Apr 5, 2024

At least need to have the ability to disable it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants