Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong permission setup for HiveMQ container #8399

Merged
merged 6 commits into from
Feb 28, 2024

Conversation

SgtSilvio
Copy link
Contributor

@SgtSilvio SgtSilvio commented Feb 28, 2024

The line chmod -R 777 /opt/hivemq/extensions is problematic when running the HiveMQ container with a non-root user.
It is now made optional (removing it completely is not possible because older HiveMQ container images still need to be supported).

@eddumelendez
Copy link
Member

Hi @SgtSilvio can you add a test to reproduce the issue, please?

@SgtSilvio
Copy link
Contributor Author

SgtSilvio commented Feb 28, 2024

@eddumelendez the issue happens with hivemq-ce version 2023.4 as it runs the container as a non-root user by default. So I updated the version used in the tests to 2023.4. I kept an older version in some tests to also cover older versions that run as the root user.

@eddumelendez eddumelendez merged commit af5863c into testcontainers:main Feb 28, 2024
95 checks passed
@eddumelendez
Copy link
Member

Thanks for your contribution, @SgtSilvio !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants