Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename SA_PASSWORD to MSSQL_SA_PASSWORD as SA_PASSWORD is deprecated #8987

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

jedla97
Copy link
Contributor

@jedla97 jedla97 commented Jul 24, 2024

Updating SA_PASSWORD to MSSQL_SA_PASSWORD as SA_PASSWORD is marked deprecated for some time (I see this note in MSSQL 2017 docs). To see that note you can look here https://learn.microsoft.com/en-us/sql/linux/quickstart-install-connect-docker?view=sql-server-ver16&tabs=cli&pivots=cs1-bash#run-the-container-2

@jedla97 jedla97 requested a review from a team as a code owner July 24, 2024 16:23
@eddumelendez
Copy link
Member

Thanks for your contribution, @jedla97 ! Do you know if there is a specific version where that env var was added? Just asking in order to see if we can avoid breaking changes to consumers

@jedla97
Copy link
Contributor Author

jedla97 commented Jul 24, 2024

@eddumelendez I didn't find it in release notes, but I run it with 2017 version and it work start fine. As I didn't find 2016 version I can say for sure it will be working there. By https://endoflife.date/mssqlserver the 2016 have only security support.

@eddumelendez eddumelendez added this to the next milestone Jul 24, 2024
@eddumelendez eddumelendez merged commit daf44c4 into testcontainers:main Jul 24, 2024
100 checks passed
@eddumelendez
Copy link
Member

Thanks, @jedla97 !

@eddumelendez eddumelendez modified the milestone: next Jul 25, 2024
@jedla97 jedla97 deleted the mssql-password branch July 25, 2024 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants