Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate what to do about "localnpipe" on windows #415

Open
alexanderankin opened this issue Jan 23, 2024 · 1 comment
Open

Investigate what to do about "localnpipe" on windows #415

alexanderankin opened this issue Jan 23, 2024 · 1 comment

Comments

@alexanderankin
Copy link
Collaborator

alexanderankin commented Jan 23, 2024

it has been some time. the urllib3/docker-py incompatibilities are fixed. the time of using named pipes on windows is here. the question is how to deal with them in this library. for now, i am suggesting a fix like:

class DockerContainer:
    # ...
    def get_container_host_ip(self) -> str:
        # ...
        # see https://github.com/testcontainers/testcontainers-python/issues/415
        if host == "localnpipe" and "Windows" == system():
            return "localhost"
        # ...

but it really should get investigated in the short term.

@alexanderankin
Copy link
Collaborator Author

#100

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant