Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update compose to work with both "docker-compose" as well as "docker compose" #312

Closed
wants to merge 4 commits into from

Conversation

jhnnsrs
Copy link

@jhnnsrs jhnnsrs commented Feb 24, 2023

Fixes #306

Sorry for the deletion of the old pull-request.

Fixed using docker compose with the new "docker compose" api as well
as the older "docker-compose" api.
Copy link
Collaborator

@ash1425 ash1425 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@pffijt pffijt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The whole repository has now a different structure (after pr #290) could you apply the changes in compose/testcontainers/compose/init.py?

@bercikr
Copy link

bercikr commented May 25, 2023

what do we need to do to get this approved, can I reopen the pull request. We are hitting an issue related to this...

@tillahoffmann
Copy link
Collaborator

tillahoffmann commented May 25, 2023

We need a rebase on main to get this merged and adopt the new repository structure.

@tillahoffmann
Copy link
Collaborator

Closing in favor of #362.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow configuring the docker-compose executable path
5 participants