Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#415 fix up localnpipe -> localhost on windows #427

Merged
merged 1 commit into from
Feb 20, 2024
Merged

#415 fix up localnpipe -> localhost on windows #427

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions core/testcontainers/core/container.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import os
from platform import system
from typing import Optional, Tuple

from docker.models.containers import Container
Expand Down Expand Up @@ -92,6 +93,9 @@ def get_container_host_ip(self) -> str:
host = self.get_docker_client().host()
if not host:
return "localhost"
# see https://github.com/testcontainers/testcontainers-python/issues/415
if host == "localnpipe" and "Windows" == system():
return "localhost"

# check testcontainers itself runs inside docker container
if inside_container() and not os.getenv("DOCKER_HOST"):
Expand Down
Loading