feat(redis): add AsyncRedis support #434
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hey @bearrito thanks for the contrib! Apologies for the failures on the different module things, I'll double check my mistake on it. Will fix so you can rebase and have your checks passing! :) |
|
@totallyzen I'm 99% sure I did the wrong thing with dependencies. I can see they should go under the module group extras. In another issue (#436) I'm trying to create a new module. I think the docs are out of date on this - https://testcontainers-python.readthedocs.io/en/latest/README.html |
totallyzen
reviewed
Mar 1, 2024
pyproject.toml
Outdated
Comment on lines
86
to
87
| anyio = "^4.3.0" | ||
| pre-commit = "^3.6.2" |
There was a problem hiding this comment.
for these,
- make
anyioa dev dependency for now - you don't actually needanyioto run redis - I tend not to install
pre-commitunder poetry because then you will need poetry-ception - just usepip install pre-commitfor that one! - the rest should be fine, and in fact after fix(build): early exit strategy for modules #437 you seem to be just fine so fixing these two should be all you need.
|
I fixed the early-exit strat in #437 - was a doozy but I'm happy with the results! (dynamic matrix, no errors!) |
totallyzen
changed the title
|
Updated. |
…v and CI (testcontainers#438) I could not install pre-commit handler because the package was missing in [tool.poetry.group.dev.dependencies]. I also updated the configuration for the pre-commit handler as black and ruff packages were outdated. Also removed deprecation for ruff v0.3.0 config in pyproject.toml. --------- Co-authored-by: Balint Bartha <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for async redis
Discussed somewhat here - #374
Tested in the recently fixed devcontainers.
There is currently no working tests for pub/sub.