Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add Cockroach DB Module to Testcontainers #608

Merged
merged 2 commits into from
Jun 18, 2024

Conversation

joelhess
Copy link
Contributor

@joelhess joelhess commented Jun 17, 2024

Adds [Cockroach DB] (https://www.cockroachlabs.com/) module to use with Test containers

I had done this previously under #281, but opted to just redo it rather than try to rebase all the things.

  • Create a new feature directory and populate it with the package structure described in the documentation. Copying one of the existing features is likely the best way to get started.
  • Implement the new feature (typically in __init__.py) and corresponding tests.
  • Update the feature README.rst and add it to the table of contents (toctree directive) in the top-level README.rst.
  • [] Add a line [feature name] to the list of components in the GitHub Action workflow in .github/workflows/main.yml to run tests, build, and publish your package when pushed to the main branch.
  • Rebase your development branch on main (or merge main into your development branch).
  • Add Package to pyproject.toml
  • Add a line -e file:[feature name] to requirements.in and open a pull request. Opening a pull request will automatically generate lock files to ensure reproducible builds (see the pip-tools documentation for details). Finally, run python get_requirements.py --pr=[your PR number] to fetch the updated requirement files (the build needs to have succeeded).

@joelhess joelhess changed the title Add CRDB Module to Testcontainers Add Cockroach DB Module to Testcontainers Jun 17, 2024
@alexanderankin alexanderankin added the community-feat feature but its a community module so we wont bump tc core for it label Jun 18, 2024
@alexanderankin alexanderankin changed the title Add Cockroach DB Module to Testcontainers fix: Add Cockroach DB Module to Testcontainers Jun 18, 2024
@alexanderankin
Copy link
Collaborator

will merge whenever the tests run

Copy link

codecov bot commented Jun 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@0768490). Learn more about missing BASE report.

Current head 31a18c3 differs from pull request most recent head 053e706

Please upload reports for the commit 053e706 to get more accurate results.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #608   +/-   ##
=======================================
  Coverage        ?   75.18%           
=======================================
  Files           ?       10           
  Lines           ?      548           
  Branches        ?       77           
=======================================
  Hits            ?      412           
  Misses          ?      110           
  Partials        ?       26           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alexanderankin alexanderankin merged commit 4aff679 into testcontainers:main Jun 18, 2024
13 checks passed
alexanderankin pushed a commit that referenced this pull request Jun 20, 2024
🤖 I have created a release *beep* *boop*
---


##
[4.6.0](testcontainers-v4.5.1...testcontainers-v4.6.0)
(2024-06-18)


### Features

* **core:** Added ServerContainer
([#595](#595))
([0768490](0768490))
* **core:** Image build (Dockerfile support)
([#585](#585))
([54c88cf](54c88cf))


### Bug Fixes

* Add Cockroach DB Module to Testcontainers
([#608](#608))
([4aff679](4aff679))
* Container for Milvus database
([#606](#606))
([ec76df2](ec76df2))
* move TESTCONTAINERS_HOST_OVERRIDE to config.py
([#603](#603))
([2a5a190](2a5a190)),
closes
[#602](#602)
* **mqtt:** Add mqtt.MosquittoContainer
([#568](#568))
([#599](#599))
([59cb6fc](59cb6fc))


### Documentation

* **main:** Private registry
([#598](#598))
([9045c0a](9045c0a))
* Update private registry instructions
([#604](#604))
([f5a019b](f5a019b))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-feat feature but its a community module so we wont bump tc core for it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants