fix: delete chars from value at maxlength (#909)

testing-library · Apr 11, 2022 · f5049c4 · f5049c4
1 parent 627a5cf
commit f5049c4
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/src/utils/edit/input.ts b/src/utils/edit/input.ts
@@ -128,7 +128,7 @@ function editInputElement(
 ) {
   let dataToInsert = data
   const spaceUntilMaxLength = getSpaceUntilMaxLength(element)
-  if (spaceUntilMaxLength !== undefined) {
+  if (spaceUntilMaxLength !== undefined && data.length > 0) {
     if (spaceUntilMaxLength > 0) {
       dataToInsert = data.substring(0, spaceUntilMaxLength)
     } else {

diff --git a/tests/utils/edit/input.ts b/tests/utils/edit/input.ts
@@ -235,10 +235,10 @@ test('prevent input on `beforeinput` event', () => {
 
 cases(
   'maxlength',
-  ({html, data, expectedValue}) => {
+  ({html, data, inputType, expectedValue}) => {
     const {element, eventWasFired} = render(html)
 
-    input(createConfig(), element, data)
+    input(createConfig(), element, data, inputType)
 
     expect(element).toHaveValue(expectedValue)
     expect(eventWasFired('beforeinput')).toBe(true)
@@ -270,6 +270,12 @@ cases(
       data: '',
       expectedValue: '',
     },
+    'delete data when maxlength is reached': {
+      html: `<input maxlength="3" value="foo"/>`,
+      data: '',
+      inputType: 'deleteContentForward',
+      expectedValue: 'oo',
+    },
   },
 )