migrate LaunchSuite and SuiteGenerator classes from "org.testng.xml" #564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in testng codebase
krmahadevan
approved these changes
Dec 31, 2023
|
@missedone - We just need to ensure that it works fine. I will go ahead with removing those 2 classes and then maybe you can vet out the eclipse plugin with the snapshot of testng 7.10.0 and check if all is well. |
|
sounds good, thx @krmahadevan |
|
@missedone - My changes are merged to |
juherr
approved these changes
Jan 14, 2024
|
merging this PR now. @krmahadevan , i will raise a separate PR in testng-remote and testng-eclipse as the testing commit testng-team/testng@94bf011 breaks testng-remote after removing the arg |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #562
@krmahadevan , i didn't read the detail of LaunchSuite.java and SuiteGenerator.java, i simply copied them under the same package so no code change required.