Add additional condition for assertEqualsNoOrder #2723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juherr
reviewed
Jan 30, 2022
|
Tests added. |
juherr
approved these changes
Jan 31, 2022
krmahadevan
approved these changes
Jan 31, 2022
krmahadevan
requested changes
Jan 31, 2022
There was a problem hiding this comment.
@Dymitriux - We have failures in tests due to formatting failures.
Please do the following:
- From the command prompt run
./gradlew autostyleApply - Update this PR with the new changes (the above command will automatically apply formatting changes)
- Run
./gradlew checkand ensure that there are no failures. - Push and let me know once done.
For more details please refer to https://github.com/cbeust/testng/blob/master/.github/CONTRIBUTING.md
|
@krmahadevan Formatting changes pushed, sorry for that, forgot about autoStyleApply after adding test cases, now it should be ok. |
krmahadevan
approved these changes
Jan 31, 2022
|
@Dymitriux - Thanks for taking the time with raising this PR. This is now merged. |
|
@krmahadevan No problem, hope I will find more time for contribution. I will look into issues marked with milestone 7.6.0 |
|
@Dymitriux that would be awesome! Looking forward to more contributions from you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add additional condition for assertEqualsNoOrder collection and iterators to check also size
Fixes # .
Did you remember to?
CHANGES.txt./gradlew autostyleApplyWe encourage pull requests that:
If your pull request involves fixing SonarQube issues then we would suggest that you please discuss this with the
TestNG-dev before you spend time working on it.
Note: For more information on contribution guidelines please make sure you refer our Contributing section for detailed set of steps.