SuiteRunner could not be initial by default Configuration #2744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krmahadevan
reviewed
Mar 22, 2022
| public void testSuiteRunnerWithDefaultConfiguration() { | ||
| TestNG testNG = create(SuiteRunnerIssueTestSample.class); | ||
| testNG.run(); | ||
| Assert.assertNotNull(SuiteRunnerIssueTestSample.suiteRunner); |
There was a problem hiding this comment.
@bj-9527 - This assertion looks suspicious. Can we change this assertion such that it checks if the run() was successful by checking the exit code instead ?
There was a problem hiding this comment.
OK, I have change Assert to check status
krmahadevan
approved these changes
Mar 22, 2022
juherr
approved these changes
Mar 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2743.
Did you remember to?
CHANGES.txt./gradlew autostyleApplyWe encourage pull requests that:
If your pull request involves fixing SonarQube issues then we would suggest that you please discuss this with the
TestNG-dev before you spend time working on it.
Note: For more information on contribution guidelines please make sure you refer our Contributing section for detailed set of steps.