Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Files.copy() such that parent dirs are created #2764

Merged
merged 1 commit into from
May 22, 2022

Conversation

krmahadevan
Copy link
Member

Closes #2761

Also toggled the version back to a bug fix version

Fixes #2761 .

Did you remember to?

  • Add test case(s)
  • Update CHANGES.txt
  • Auto applied styling via ./gradlew autostyleApply

We encourage pull requests that:

  • Add new features to TestNG (or)
  • Fix bugs in TestNG

If your pull request involves fixing SonarQube issues then we would suggest that you please discuss this with the
TestNG-dev before you spend time working on it.

Note: For more information on contribution guidelines please make sure you refer our Contributing section for detailed set of steps.

@@ -5,7 +5,7 @@ kotlin.code.style=official
# Note: testng.kotlin-library.gradle.kts adds kotlin-stdlib for testImplementation
kotlin.stdlib.default.dependency=false

testng.version=7.7.0
testng.version=7.6.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not the latest version or the next one?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The last released version was 7.6.0. Am guessing that this qualifies to be a bugfix release. Hence the version as 7.6.1

7.7.0 - Will be the version for the next release (I have already moved the milestones etc., Dont want to go through that ritual once again)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice if we release 7.6.x during this year and maybe once per year lift the major version to allow smaller releases from time to time.

testng-core/src/test/java/testhelper/JarCreator.java Outdated Show resolved Hide resolved
@krmahadevan krmahadevan force-pushed the fix_2761 branch 2 times, most recently from 370c8cd to b649672 Compare May 19, 2022 10:51
Closes testng-team#2761

Also toggled the version back to a bug fix version
@krmahadevan krmahadevan merged commit 53ea2ad into testng-team:master May 22, 2022
@krmahadevan krmahadevan deleted the fix_2761 branch May 22, 2022 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exception: ERROR java.nio.file.NoSuchFileException: /tmp/testngXmlPathInJar-15086412835569336174
3 participants