JarFileUtils.delete(File f) throw actual exception (instead of FileNotFound) when file cannot be deleted #2825

[speedythesnail]

Fixes #2825 .

Changed JarFileUtils.delete(File f) throw actual exception (instead of FileNotFound) when file cannot be deleted, as recommended by SonarSource (https://rules.sonarsource.com/java/tag/error-handling/RSPEC-4042).

If the file is not found, a log message is generated.
Files.deleteIfExists() also throws:

DirectoryNotEmptyException - if the file is a directory and could not otherwise be deleted because the directory is not empty (optional specific exception)

IOException - if an I/O error occurs

SecurityException - In the case of the default provider, and a security manager is installed, the SecurityManager.checkDelete(String) method is invoked to check delete access to the file.

Did you remember to?

• Add test case(s)
• Update CHANGES.txt
• Auto applied styling via ./gradlew autostyleApply

[juherr]

Is there any way to add a test that will enforce the fix?

[juherr]

I think there is no need of comments here because deleteIfExists is definitively better.

[speedythesnail]

Removed the comment

[juherr]

The behavior is changed and maybe some users prefere the current one.
Please make the behavior change configurable.
By default the exception looks better because we expect the deletion.

[speedythesnail]

Removed the logging option, I agree that it should throw an exception instead.

[speedythesnail]

Is there any way to add a test that will enforce the fix?

I was going to write a unit test for the delete method but it is private, I did not think it would be a good idea to make it public.

Some of the other tests should already fail if this method throws an exception, but it seems like this is a rare circumstance that I've so far been the only one to experience on my specific platform and application.