wazevo: fuzz, fix load_splat #1810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
marked as draft because I want to add a proper unit test EDIT done. |
mathetake
reviewed
Oct 22, 2023
mathetake
reviewed
Oct 22, 2023
mathetake
approved these changes
Oct 22, 2023
Signed-off-by: Edoardo Vacchi <[email protected]>
Signed-off-by: Edoardo Vacchi <[email protected]>
Signed-off-by: Edoardo Vacchi <[email protected]>
Co-authored-by: Takeshi Yoneda <[email protected]> Signed-off-by: Edoardo Vacchi <[email protected]>
|
rebased because of conflict with fuzzcases_test.go |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1496
that took a while to figure out, because the fuzz case was large and did not minimize.
I originally took a shortcut to implementing load_splat, and apparently no other tests covered this case 😅
Signed-off-by: Edoardo Vacchi [email protected]