add caviar staking strategy #28
Conversation
| address[] memory rewardTokens_ = new address[](1); | ||
|
|
||
| // caviarChef shows rewards in wUSDR but harvest returns USDR need to override | ||
| rewardTokens_[0] = USDR_TOKEN; |
There was a problem hiding this comment.
@belbix Here is a caveat. According to the CAVIAR_CHEF there is an only one reward token - wURSD, but harvest sends USDR and CAVIAR tokens. I decided to use only USDR as reward token. Not sure if it is correct.
| // ******************************************************* | ||
|
|
||
| /// @dev Set new reward tokens | ||
| function setRewardTokens(address[] memory rts) external restricted { |
There was a problem hiding this comment.
I decided to include this method since Tangible is famous for upgrading it's tokens USDR is v3. There is a high probability that reward tokens will be updated.
| // so we need to store CAVIAR balance before harvest and send this value to the "_liquidateRewards" method. | ||
| CAVIAR_CHEF.harvest(address(this)); | ||
| } | ||
| _liquidateRewards(silently, undBalanceBefore); |
There was a problem hiding this comment.
do we need liquidate if no tokens? better to move this into the if statement
There was a problem hiding this comment.
In case of withdrawAndClaimFromPool we are calling CAVIAR_CHEF.withdrawAndHarvest, we will have rewards which needs to be liquidated.
| pendingReward = reward; | ||
| } catch {} | ||
|
|
||
| uint undBalanceBefore = IERC20(_underlying()).balanceOf(address(this)); |
There was a problem hiding this comment.
We need to store amount of underlying (CAVIAR) before harvest to liquidate only harvested CAVIAR tokens.
| uint toCompound = amount * (_BUY_BACK_DENOMINATOR - bbRatio) / _BUY_BACK_DENOMINATOR; | ||
| uint toGov = amount - toCompound; | ||
| if (toCompound != 0) { | ||
| _liquidate(rt, _underlying(), toCompound, silently); |
There was a problem hiding this comment.
read slots in a loop not so good
| } | ||
| } | ||
|
|
||
| uint undBalance = IERC20(_underlying()).balanceOf(address(this)) - undBalBeforeHarvest; |
| } | ||
|
|
||
| //slither-disable-next-line unused-state | ||
| uint256[45] private ______gap; |
There was a problem hiding this comment.
use 50 - count of variables (it's zero here)
AlehNat
force-pushed
the
caviar_strategy
branch
from
e63c095
to
e0deb5d
Compare
AlehNat
force-pushed
the
caviar_strategy
branch
from
4065b83
to
0184c5e
Compare
No description provided.