Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compatibility with six >= 1.11; Fix import ProtocolTreeNode #2379

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix compatibility with six >= 1.11; Fix import ProtocolTreeNode #2379

wants to merge 2 commits into from

Conversation

noahfx
Copy link

@noahfx noahfx commented Jan 3, 2018 •
edited
Loading

It seems the fix is removing the __metaclass__ keyword when with_metaclass is used
as it is pointed at benjaminp/six#210 (comment)

This fixes #2259

Also this fixes: Import of ProtocolTreeNode #2120

@noahfx noahfx mentioned this pull request Jan 3, 2018
Open
@noahfx noahfx changed the title Fix compatibility with six >= 1.11 Fix compatibility with six >= 1.11; Fix import ProtocolTreeNode Jan 6, 2018
@infinisil infinisil mentioned this pull request Feb 13, 2018
Closed
@tgalal tgalal added this to the Next milestone May 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Next
Development

Successfully merging this pull request may close these issues.

TypeError: Error when calling the metaclass bases
2 participants
@noahfx @tgalal