Do not fail on missing release notes token if unused

tgstation · Aug 17, 2024 · 50eaadd · 50eaadd
1 parent 3aabfa6
commit 50eaadd
Showing 1 changed file with 25 additions and 26 deletions.
diff --git a/tools/Tgstation.Server.ReleaseNotes/Program.cs b/tools/Tgstation.Server.ReleaseNotes/Program.cs
@@ -110,20 +110,7 @@ static async Task<int> Main(string[] args)
 						break;
 				}
 
-			const string ReleaseNotesEnvVar = "TGS_RELEASE_NOTES_TOKEN";
-			var githubToken = Environment.GetEnvironmentVariable(ReleaseNotesEnvVar);
-			if (String.IsNullOrWhiteSpace(githubToken) && !doNotCloseMilestone && !ensureRelease)
-			{
-				Console.WriteLine("Missing " + ReleaseNotesEnvVar + " environment variable!");
-				return 3;
-			}
-
 			var client = new GitHubClient(new Octokit.ProductHeaderValue("tgs_release_notes"));
-			if (!String.IsNullOrWhiteSpace(githubToken))
-			{
-				client.Credentials = new Credentials(githubToken);
-			}
-
 			try
 			{
 				if (ensureRelease)
@@ -139,17 +126,6 @@ static async Task<int> Main(string[] args)
 					return await EnsureRelease(client);
 				}
 
-				if (linkWinget)
-				{
-					if (args.Length < 2 || !Uri.TryCreate(args[1], new UriCreationOptions(), out var actionsUrl))
-					{
-						Console.WriteLine("Missing/Invalid actions URL!");
-						return 30;
-					}
-
-					return await Winget(client, actionsUrl, null);
-				}
-
 				if (ciCheck)
 				{
 					if (args.Length < 5)
@@ -161,7 +137,6 @@ static async Task<int> Main(string[] args)
 					return await CICheck(client, args[1], args[2], Enum.Parse<CheckMode>(args[3]), Int64.Parse(args[4]));
 				}
 
-
 				if (genToken)
 				{
 					if (args.Length < 3)
@@ -180,6 +155,30 @@ static async Task<int> Main(string[] args)
 					return 0;
 				}
 
+				const string ReleaseNotesEnvVar = "TGS_RELEASE_NOTES_TOKEN";
+				var githubToken = Environment.GetEnvironmentVariable(ReleaseNotesEnvVar);
+				if (String.IsNullOrWhiteSpace(githubToken) && !doNotCloseMilestone && !ensureRelease)
+				{
+					Console.WriteLine("Missing " + ReleaseNotesEnvVar + " environment variable!");
+					return 3;
+				}
+
+				if (!String.IsNullOrWhiteSpace(githubToken))
+				{
+					client.Credentials = new Credentials(githubToken);
+				}
+
+				if (linkWinget)
+				{
+					if (args.Length < 2 || !Uri.TryCreate(args[1], new UriCreationOptions(), out var actionsUrl))
+					{
+						Console.WriteLine("Missing/Invalid actions URL!");
+						return 30;
+					}
+
+					return await Winget(client, actionsUrl, null);
+				}
+
 				if (shaCheck)
 				{
 					if (args.Length < 2)
@@ -1684,7 +1683,7 @@ enum CheckMode
 			Success,
 			Failure,
 		}
-		
+
 		static async ValueTask<int> CICheck(GitHubClient gitHubClient, string ciTargetSha, string pemBase64, CheckMode mode, long runID)
 		{
 			await GenerateAppCredentials(gitHubClient, pemBase64, false);