Skip to content

Commit

Permalink
DEV: Remove webdrivers gem that is causing problem with updating chrome
Browse files Browse the repository at this point in the history
According to the maintainer of the `webdrivers` gem, the gem is no
longer needed if we already have selenium-webdriver installed.

See titusfortner/webdrivers#247 (comment)
  • Loading branch information
tgxworld committed Jul 19, 2023
1 parent 77b4e42 commit 2fd282f
Show file tree
Hide file tree
Showing 4 changed files with 1 addition and 14 deletions.
4 changes: 0 additions & 4 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -204,10 +204,6 @@ jobs:
if: matrix.build_type == 'system'
run: bin/ember-cli --build

- name: Setup Webdriver
if: matrix.build_type == 'system'
run: bin/rails runner "require 'webdrivers'; Webdrivers::Chromedriver.required_version='114.0.5735.90'; Webdrivers::Chromedriver.update"

- name: Core System Tests
if: matrix.build_type == 'system' && matrix.target == 'core'
run: RAILS_ENABLE_TEST_LOG=1 RAILS_TEST_LOG_LEVEL=error PARALLEL_TEST_PROCESSORS=4 bin/turbo_rspec --use-runtime-info --profile=50 --verbose --format documentation spec/system
Expand Down
1 change: 0 additions & 1 deletion Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,6 @@ group :test do
gem "simplecov", require: false
gem "selenium-webdriver", require: false
gem "test-prof"
gem "webdrivers", require: false
gem "rails-dom-testing", require: false
end

Expand Down
5 changes: 0 additions & 5 deletions Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -510,10 +510,6 @@ GEM
hkdf (~> 1.0)
jwt (~> 2.0)
openssl (~> 3.0)
webdrivers (5.2.0)
nokogiri (~> 1.6)
rubyzip (>= 1.3.0)
selenium-webdriver (~> 4.0)
webmock (3.18.1)
addressable (>= 2.8.0)
crack (>= 0.3.2)
Expand Down Expand Up @@ -668,7 +664,6 @@ DEPENDENCIES
unf
unicorn
web-push
webdrivers
webmock
webrick
yaml-lint
Expand Down
5 changes: 1 addition & 4 deletions spec/rails_helper.rb
Original file line number Diff line number Diff line change
Expand Up @@ -59,12 +59,9 @@ def call(env)
require "sidekiq/testing"
require "test_prof/recipes/rspec/let_it_be"
require "test_prof/before_all/adapters/active_record"
require "webdrivers"
require "selenium-webdriver"
require "capybara/rails"

Webdrivers::Chromedriver.required_version = "114.0.5735.90"

# The shoulda-matchers gem no longer detects the test framework
# you're using or mixes itself into that framework automatically.
Shoulda::Matchers.configure do |config|
Expand Down Expand Up @@ -252,7 +249,7 @@ def fab!(name, &blk)

SiteSetting.provider = TestLocalProcessProvider.new

WebMock.disable_net_connect!(allow_localhost: true, allow: [Webdrivers::Chromedriver.base_url])
WebMock.disable_net_connect!(allow_localhost: true)

if ENV["CAPYBARA_DEFAULT_MAX_WAIT_TIME"].present?
Capybara.default_max_wait_time = ENV["CAPYBARA_DEFAULT_MAX_WAIT_TIME"].to_i
Expand Down

0 comments on commit 2fd282f

Please sign in to comment.