remove uses of github.com/golang/glog #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're using dependencies with this license in many places, and it should be ok to use. Signed-off-by: Sebastiaan van Stijn <[email protected]>
license-check: add BSD-3-Clause to allow-list
Older versions may have issues when running recent Alpine images, due to seccomp profiles not being up to date with latest kernels. Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Hoping to fix:
Output from proc 3:
flag provided but not defined: -ginkgo.timeout
Usage of /e2e.test:
-alsologtostderr
log to standard error as well as files
-ginkgo.dryRun
If set, ginkgo will walk the test hierarchy without actually running anything. Best paired with -v.
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Update to Go 1.16
glog has the same issue as k8s.io/klog, and is calling `user.Current()` inside an `init()`; see kubernetes/klog@466fbb6 Calling `user.Current()` on Windows can result in remove connections being made to get the user's information, which can be a heavy call. glog was only used in a single location, so we may as well remove it. Signed-off-by: Sebastiaan van Stijn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
glog has the same issue as k8s.io/klog, and is calling
user.Current()inside an
init(); see kubernetes/klog@466fbb6Calling
user.Current()on Windows can result in remove connections beingmade to get the user's information, which can be a heavy call. See docker/cli#2420 and docker/cli#2515
glog was only used in a single location, so we may as well remove it.