Skip to content
This repository has been archived by the owner on Jan 15, 2021. It is now read-only.

CI error: name node_win_onecore is not defined while evaluating condition 'node_win_onecore==1' in leveldown-mobile/deps/leveldb/leveldb.gyp while loading dependencies of binding.gyp while trying to load binding.gyp #1509

Closed
larryonoff opened this issue Nov 11, 2016 · 6 comments
Assignees

Comments

@larryonoff
Copy link
Contributor

larryonoff commented Nov 11, 2016

This's very often error on CI. We need to have some final solution for this. Because we're having this issue very often, so build doesn't work.

See the logs.

@larryonoff larryonoff changed the title CI error: name node_win_onecore is not defined while evaluating condition 'node_win_onecore==1' in /Users/thali/Github/ThaliTest/www/jxcore/node_modules/leveldown-mobile/deps/leveldb/leveldb.gyp while loading dependencies of binding.gyp while trying to load binding.gyp CI error: name node_win_onecore is not defined while evaluating condition 'node_win_onecore==1' in leveldown-mobile/deps/leveldb/leveldb.gyp while loading dependencies of binding.gyp while trying to load binding.gyp Nov 11, 2016
@larryonoff
Copy link
Contributor Author

@enricogior maybe you can provide some recommendation how to setup CI properly to fix this issue. But for now we only made hacky solutions.

@larryonoff
Copy link
Contributor Author

I've found some details here Level/leveldown-mobile#11.

@enricogior
Copy link
Member

@larryonoff
the fix that you linked is not currently in the branch used by JXcore, and I guess it's not in the module downloaded by the build process in Thali.

@larryonoff
Copy link
Contributor Author

As a temporary solution we have to add variable 'node_win_onecore': 'false' in common.gypi for

  • ~/.node-gyp/{NODE-VERSION}/include/node/common.gypi
  • ~/.node-gyp/jxb311/common.gypi

It looks that this should be done each time when node and jxcore updated.

@enricogior
Copy link
Member

Assigning the issue to Ilya, he has found that the error was happening when trying to compile leveldown-mobile using node's npm instead of jxcore.

@enricogior enricogior assigned larryonoff and unassigned enricogior Nov 18, 2016
larryonoff pushed a commit to thaliproject/CI that referenced this issue Nov 21, 2016
- add code signing details about 'com.thali.test' #1423
- add 'node_win_onecore' error details into FAQ thaliproject/Thali_CordovaPlugin#1509
larryonoff pushed a commit to thaliproject/CI that referenced this issue Nov 21, 2016
- add code signing details about 'com.thali.test' thaliproject/Thali_CordovaPlugin#1423
- add 'node_win_onecore' error details into FAQ thaliproject/Thali_CordovaPlugin#1509
@larryonoff
Copy link
Contributor Author

larryonoff commented Nov 21, 2016

Fixed in PR #1523. Waiting for PR review.

CI documentation to be updated with the issue details.

larryonoff pushed a commit to thaliproject/CI that referenced this issue Nov 21, 2016
- add code signing details about 'com.thali.test' thaliproject/Thali_CordovaPlugin#1423
- add 'node_win_onecore' error details into FAQ thaliproject/Thali_CordovaPlugin#1509
larryonoff pushed a commit to thaliproject/CI that referenced this issue Nov 21, 2016
- add code signing details about 'com.thali.test' thaliproject/Thali_CordovaPlugin#1423
- add 'node_win_onecore' error details into FAQ thaliproject/Thali_CordovaPlugin#1509
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants