Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DefaultSettings.useSocks5 should return true #79

Open
sisbell opened this issue Feb 26, 2019 · 1 comment
Open

DefaultSettings.useSocks5 should return true #79

sisbell opened this issue Feb 26, 2019 · 1 comment

Comments

@sisbell
Copy link
Contributor

sisbell commented Feb 26, 2019

Default for Tor should be Socks5
sisbell added a commit to sisbell/Tor_Onion_Proxy_Library that referenced this issue Mar 23, 2019
@sisbell
Fixes thaliproject#79: DefaultSettings.useSocks5 should return true
8ed68eb
sisbell added a commit to sisbell/Tor_Onion_Proxy_Library that referenced this issue Mar 25, 2019
@sisbell
Fixes thaliproject#79: DefaultSettings.useSocks5 should return true
19829c7
sisbell added a commit to sisbell/Tor_Onion_Proxy_Library that referenced this issue Mar 25, 2019
@sisbell
Fixes thaliproject#79: DefaultSettings.useSocks5 should return true
e5f1b3e
@sisbell
Copy link
Contributor Author

sisbell commented Mar 25, 2019

I'm setting socks5 to true for Android but leaving it as false for the Java library. This is because the smoke test sample uses socks4 so I don't want this to break.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sisbell