Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update howler dependency version #53

Merged
merged 4 commits into from
Dec 29, 2017
Merged

Conversation

dmednis
Copy link
Contributor

@dmednis dmednis commented Dec 29, 2017

Changed the howler dependency version to allow for semver patch version changes.

@thangngoc89
Copy link
Owner

Hey thank you for send us this PR but we are well awear of the semver and opted for a fixed versiom because even though howler.js follows semver, they usually introduced bugs in patches that break our production builds.

@dmednis
Copy link
Contributor Author

dmednis commented Dec 29, 2017

Fixed version it is then.

@thangngoc89
Copy link
Owner

Thank you. @Stenerson could you please check if this version of howler is working fine for you? And make a new release.

@Stenerson
Copy link
Collaborator

Yes, I'll run a few tests (hopefully today) to make sure 2.0.6 checks out and merge this.

@Stenerson Stenerson self-assigned this Dec 29, 2017
@Stenerson
Copy link
Collaborator

@dmednis let's bump to 2.0.7 since it includes a minor cosmetic fix and would get us to the most current version.

I still want to run a few tests on the stuff that was changed in 2.0.6 but we can basically get to .7 for free so let's do it.

@thangngoc89
Copy link
Owner

@Stenerson I can add greenkeeper to the project for reminding you of newer version of howler.

@Stenerson
Copy link
Collaborator

Good idea @thangngoc89.

I knew that they had a few patch releases but didn't realize that .6 fixed a nasty deprecation warning in Chrome. They don't release too often so sticking with this plan should be manageable.

@dmednis
Copy link
Contributor Author

dmednis commented Dec 29, 2017

Didn't notice there was a .7 released. But yes, upgrading to the latest would be great.

@Stenerson
Copy link
Collaborator

Stenerson commented Dec 29, 2017

2.0.7 Seems to be working fine but there's still a deprecation warning.
See goldfire/howler.js#856

@dmednis can you please update to 2.0.7 and run yarn upgrade howler to update (and commit) the yarn.lock file as well? Then I'll merge. Thanks again and be on the lookout for another bump when Howler releases a version to kill the remaining deprecation warning.

@Stenerson Stenerson merged commit efb7e7d into thangngoc89:master Dec 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants