sidecar: Add pod discovery #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxbrunet
force-pushed
the
feature/thanos-sidecar-sd
branch
5 times, most recently
from
1f9d4c6
to
570ba8b
Compare
kakkoyun
approved these changes
Mar 4, 2021
Signed-off-by: Maxime Brunet <[email protected]>
maxbrunet
force-pushed
the
feature/thanos-sidecar-sd
branch
from
570ba8b
to
ffe2bcf
Compare
|
@kakkoyun Thank you, rebased! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add Kubernetes service (and ServiceMonitor) to discover Thanos Sidecar. Expects
podLabelSelector.We also use the
kube-prometheuslibrary which can create a Sidecar service perPrometheus, but this means each time a new one is deployed Query needs to be updated. This configuration is meant to be more global, when aPrometheusis deployed in a namespace with this service, it is automatically discovered, no need to update Query.I think this will help with #132.
Verification
We have been using this configuration in all our clusters without issues for quite some time.