Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add bucket replicate component #237

Merged
merged 3 commits into from
Aug 24, 2021
Merged

Conversation

yeya24
Copy link
Contributor

@yeya24 yeya24 commented Jul 31, 2021

Signed-off-by: Ben Ye [email protected]

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Add a new bucket replicate component. The libsonnet file is modified based on the bucket.libsonnet file.

Verification

We have been using this component in production.

Signed-off-by: Ben Ye <[email protected]>
@yeya24
Copy link
Contributor Author

yeya24 commented Aug 19, 2021

cc @kakkoyun @metalmatze

Copy link
Member

@kakkoyun kakkoyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I don't get why minio related manifests have changed. Did we miss something feom previous PRs?

@yeya24
Copy link
Contributor Author

yeya24 commented Aug 21, 2021

LGTM. I don't get why minio related manifests have changed. Did we miss something feom previous PRs?

Thanks for catching this. I updated some minio manifests mistakenly and I already changed them back. PTAL

Signed-off-by: Ben Ye <[email protected]>
@yeya24
Copy link
Contributor Author

yeya24 commented Aug 24, 2021

Ready for review again. CC @kakkoyun

@kakkoyun kakkoyun merged commit add27c3 into thanos-io:main Aug 24, 2021
@yeya24 yeya24 deleted the add-bucket-replicate branch August 26, 2021 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants