-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add annotation support for serviceaccount #271
Conversation
ac18e3c
to
189ce6f
Compare
Signed-off-by: Xin Huang <[email protected]>
Signed-off-by: Xin Huang <[email protected]>
2411b93
to
18252ff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. Only one thing that caught my eye and the CI failures need to be fixed!
Co-authored-by: Kemal Akkoyun <[email protected]> Signed-off-by: Xin Huang <[email protected]>
4b63327
to
f77a6b5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to format and generate examples. You can find the necessary commands to do these in the Makefile.
Signed-off-by: Xin Huang <[email protected]>
94b3843
to
4c0c283
Compare
@kakkoyun Re-generated doc and example code. |
Changes
In EKS, It's necessary to have an IAM role to associate with a service account. (details in link).
I added the ability to customize it.
Verification
You can test it via a common config:
The generated config would be like: