Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store: allow configuration of series, series sample, and downloaded bytes limits #292

Merged
merged 7 commits into from
Feb 3, 2023
Merged

Store: allow configuration of series, series sample, and downloaded bytes limits #292

merged 7 commits into from
Feb 3, 2023

Conversation

douglascamata
Copy link
Contributor

@douglascamata douglascamata commented Jan 31, 2023 •
edited
Loading

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

  • Allow the configuration of the Store's touched series, series sample, and downloaded bytes limits.

Verification

@douglascamata douglascamata marked this pull request as ready for review January 31, 2023 16:53
@douglascamata
Copy link
Contributor Author

Depends on #293.

@douglascamata douglascamata changed the title Store: allow configuration of series touched limit Store: allow configuration of series, series sample, and downloaded bytes limits Jan 31, 2023
yeya24
yeya24 approved these changes Jan 31, 2023
View reviewed changes
Copy link
Contributor

@yeya24 yeya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

saswatamcode
saswatamcode approved these changes Feb 1, 2023
View reviewed changes
Copy link
Member

@saswatamcode saswatamcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

Just one small suggestion.

jsonnet/kube-thanos/kube-thanos-store.libsonnet Show resolved Hide resolved
@douglascamata
Assert that limits config is an object
adf2f1c 
Signed-off-by: Douglas Camata <[email protected]>
@douglascamata
Rerun CI
bc70a72 
Signed-off-by: Douglas Camata <[email protected]>
@saswatamcode saswatamcode merged commit d2cac7b into thanos-io:main Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philipgough philipgough philipgough approved these changes

@yeya24 yeya24 yeya24 approved these changes

@matej-g matej-g matej-g approved these changes

@saswatamcode saswatamcode saswatamcode approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@douglascamata @philipgough @yeya24 @matej-g @saswatamcode