Skip to content

Commit

Permalink
CHANGELOG and TODO
Browse files Browse the repository at this point in the history
Signed-off-by: milinddethe15 <[email protected]>
  • Loading branch information
milinddethe15 committed Oct 21, 2024
1 parent 7e645b1 commit 56060d9
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 2 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ We use *breaking :warning:* to mark changes that are not backward compatible (re
- [#116](https://github.com/thanos-io/objstore/pull/116) Azure: Add new storage_create_container configuration property
- [#128](https://github.com/thanos-io/objstore/pull/128) GCS: Add support for `ChunkSize` for writer.
- [#130](https://github.com/thanos-io/objstore/pull/130) feat: Decouple creating bucket metrics from instrumenting the bucket
- [#150](https://github.com/thanos-io/objstore/pull/150) Add support of roundtripper wrapper.

### Changed
- [#38](https://github.com/thanos-io/objstore/pull/38) *: Upgrade minio-go version to `v7.0.45`.
Expand Down
2 changes: 1 addition & 1 deletion providers/bos/bos.go
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ func parseConfig(conf []byte) (Config, error) {

// NewBucket new bos bucket.
func NewBucket(logger log.Logger, conf []byte, component string) (*Bucket, error) {
// TODO(https://github.com/thanos-io/objstore/pull/140): Add support for custom roundtripper.
// TODO(https://github.com/thanos-io/objstore/pull/150): Add support for roundtripper wrapper.
if logger == nil {
logger = log.NewNopLogger()
}
Expand Down
2 changes: 1 addition & 1 deletion providers/obs/obs.go
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ type Bucket struct {
}

func NewBucket(logger log.Logger, conf []byte) (*Bucket, error) {
// TODO(https://github.com/thanos-io/objstore/pull/140): Add support for custom roundtripper.
// TODO(https://github.com/thanos-io/objstore/pull/150): Add support for roundtripper wrapper.
config, err := parseConfig(conf)
if err != nil {
return nil, errors.Wrap(err, "parsing cos configuration")
Expand Down

0 comments on commit 56060d9

Please sign in to comment.