Added roundtripper wrapper as param #150
Merged
+109
−96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: milinddethe15 <[email protected]>
Signed-off-by: milinddethe15 <[email protected]>
Signed-off-by: milinddethe15 <[email protected]>
Signed-off-by: Milind Dethe <[email protected]>
GiedriusS
approved these changes
Oct 24, 2024
saswatamcode
approved these changes
Oct 24, 2024
Signed-off-by: milinddethe15 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Added a parameter in NewBucket() to pass
wrapRoundtripper func(http.RoundTripper) http.RoundTripperVerification
Created tests in which a always error returning roundtripper wrapper is passed to NewBucket() and tested whether this error is caught or not.