Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added file path to erros from DownloadFile #73

Merged
merged 2 commits into from
Aug 28, 2023
Merged

Added file path to erros from DownloadFile #73

merged 2 commits into from
Aug 28, 2023

Conversation

xBazilio
Copy link
Contributor

@xBazilio xBazilio commented Aug 25, 2023 •
edited
Loading

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Аdded file path to erros from DownloadFile

Verification

checked error message

@xBazilio
Added file path in erros from DownloadFile
900ce69 
Signed-off-by: Vasiliy Rumyantsev <[email protected]>
@xBazilio
CHANGELOG.md
169cb53 
Signed-off-by: Vasiliy Rumyantsev <[email protected]>
@xBazilio
Copy link
Contributor Author

xBazilio commented Aug 25, 2023 •
edited
Loading

Sometimes we get errors like
download block 01H5FCJSHXQMT9CKYYXKQWZD4V: copy object to file: unexpected EOF
If block has 100+ chunk files, it's hard to find out which file isn't beeing downloaded.

This PR should help debug such problems more easily.

MichaHoffmann
MichaHoffmann approved these changes Aug 28, 2023
View reviewed changes
Copy link
Contributor

@MichaHoffmann MichaHoffmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@GiedriusS GiedriusS merged commit ee96240 into thanos-io:main Aug 28, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GiedriusS GiedriusS GiedriusS approved these changes

@MichaHoffmann MichaHoffmann MichaHoffmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xBazilio @GiedriusS @MichaHoffmann