store: fix chunk pool memory leak (#1512)

Signed-off-by: Andy Bursavich <[email protected]>
thanos-io · Sep 13, 2019 · 42e9506 · 42e9506
1 parent 83583f1
commit 42e9506
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/pkg/store/bucket.go b/pkg/store/bucket.go
@@ -1275,11 +1275,13 @@ func (b *bucketBlock) readChunkRange(ctx context.Context, seq int, off, length i
 
 	r, err := b.bucket.GetRange(ctx, b.chunkObjs[seq], off, length)
 	if err != nil {
+		b.chunkPool.Put(c)
 		return nil, errors.Wrap(err, "get range reader")
 	}
 	defer runutil.CloseWithLogOnErr(b.logger, r, "readChunkRange close range reader")
 
 	if _, err = io.Copy(buf, r); err != nil {
+		b.chunkPool.Put(c)
 		return nil, errors.Wrap(err, "read range")
 	}
 	internalBuf := buf.Bytes()