Skip to content

Commit

Permalink
Fix linter pointed issues
Browse files Browse the repository at this point in the history
Signed-off-by: Kemal Akkoyun <[email protected]>
  • Loading branch information
kakkoyun committed Oct 17, 2019
1 parent 2191e78 commit 5bb1f5f
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions cmd/thanos/compact.go
Original file line number Diff line number Diff line change
Expand Up @@ -244,6 +244,7 @@ func runCompact(
statusProber := prober.NewProber(component, logger, prometheus.WrapRegistererWithPrefix("thanos_", reg))
// Initiate HTTP listener providing metrics endpoint and readiness/liveness probes.
if err := scheduleHTTPServer(g, logger, reg, statusProber, httpBindAddr, nil, component); err != nil {
cancel()
return errors.Wrap(err, "schedule HTTP server with probes")
}

Expand Down
2 changes: 1 addition & 1 deletion cmd/thanos/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -333,7 +333,7 @@ func newStoreGRPCServer(logger log.Logger, reg prometheus.Registerer, tracer ope
return s
}

// scheduleHTTPServer starts a goroutine that servers HTTP endpoint with default endpoints providing Prometheus metrics,
// scheduleHTTPServer starts a run.Group that servers HTTP endpoint with default endpoints providing Prometheus metrics,
// profiling and liveness/readiness probes.
func scheduleHTTPServer(g *run.Group, logger log.Logger, reg *prometheus.Registry, readinessProber *prober.Prober, httpBindAddr string, handler http.Handler, comp component.Component) error {
mux := http.NewServeMux()
Expand Down

0 comments on commit 5bb1f5f

Please sign in to comment.