-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
rules: fix silly mistakes in the rules API (#2957)
* rules: fix silly mistakes in the rules API Fixes #2938 and is a follow up to #2925. Changes: * Copying all fields properly to the group-level as well * Set TZ to UTC explicitly in other `time.Time` fields to avoid a panic * Make sure that `RuleGroup` always has an empty array in the `rules` field because that's customary and that is what the new React UI expects. Manual testing for now. Signed-off-by: Giedrius Statkevičius <[email protected]> * rules: remove DeprecatedPartialResponseStrategy It has been marked deprecated for more than 2 months. Remove it finally. Signed-off-by: Giedrius Statkevičius <[email protected]> * e2e: rules_api: add checks for non-zero values Signed-off-by: Giedrius Statkevičius <[email protected]> * test: e2e: fix rule test Signed-off-by: Giedrius Statkevičius <[email protected]> * test: rule: fix govet error Signed-off-by: Giedrius Statkevičius <[email protected]> * Update CHANGELOG.md Signed-off-by: Giedrius Statkevičius <[email protected]> Co-authored-by: Lucas Servén Marín <[email protected]> * Update CHANGELOG.md Signed-off-by: Giedrius Statkevičius <[email protected]> Co-authored-by: Lucas Servén Marín <[email protected]> Co-authored-by: Lucas Servén Marín <[email protected]>
- Loading branch information
Showing
10 changed files
with
277 additions
and
266 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.