Fix flag names

thanos-io · May 20, 2019 · d8e84f5 · d8e84f5
1 parent a653cbd
commit d8e84f5
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 8 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -13,7 +13,7 @@ We use *breaking* word for marking changes that are not backward compatible (rel
 
 ### Added
 
-- [#1077](https://github.com/improbable-eng/thanos/pull/1077) Thanos Store gateway now supports time & duration based partitioning using `--min-time` & `--max-time` flags. Flags can be set to constant time in RFC3339 format or time duration relative to current time, such as -1.5d or 2h45m. Valid duration units are ms, s, m, h, d, w, y.
+- [#1077](https://github.com/improbable-eng/thanos/pull/1077) Thanos Store gateway now supports time & duration based partitioning using `--min-block-start-time` & `--max-block-start-time` flags. Flags can be set to constant time in RFC3339 format or time duration relative to current time, such as -1.5d or 2h45m. Valid duration units are ms, s, m, h, d, w, y. Checkout Store documentation for more info.
 - [#1094](https://github.com/improbable-eng/thanos/pull/1094) Allow configuring the response header timeout for the S3 client.
 
 ### Changed

diff --git a/cmd/thanos/store.go b/cmd/thanos/store.go
@@ -52,16 +52,16 @@ func registerStore(m map[string]setupFunc, app *kingpin.Application, name string
 	blockSyncConcurrency := cmd.Flag("block-sync-concurrency", "Number of goroutines to use when syncing blocks from object storage.").
 		Default("20").Int()
 
-	minBlockStartTime := model.TimeOrDuration(cmd.Flag("--min-block-start-time", "Start of time range limit to serve. Thanos Store serves only blocks, which have start time greater than this value. Option can be a constant time in RFC3339 format or time duration relative to current time, such as -1.5d or 2h45m. Valid duration units are ms, s, m, h, d, w, y.").
+	minBlockStartTime := model.TimeOrDuration(cmd.Flag("min-block-start-time", "Start of time range limit to serve. Thanos Store serves only blocks, which have start time greater than this value. Option can be a constant time in RFC3339 format or time duration relative to current time, such as -1.5d or 2h45m. Valid duration units are ms, s, m, h, d, w, y.").
 		Default("0000-01-01T00:00:00Z"))
 
 	maxBlockStartTime := model.TimeOrDuration(cmd.Flag("--max-block-start-time", "End of time range limit to serve. Thanos Store serves only blocks, which have start time is less than this value. Option can be a constant time in RFC3339 format or time duration relative to current time, such as -1.5d or 2h45m. Valid duration units are ms, s, m, h, d, w, y.").
 		Default("9999-12-31T23:59:59Z"))
 
-	minBlockEndTime := model.TimeOrDuration(cmd.Flag("--min-block-end-time", "Start of time range limit to serve. Thanos Store serves only blocks, which have end time greater than this value. Option can be a constant time in RFC3339 format or time duration relative to current time, such as -1.5d or 2h45m. Valid duration units are ms, s, m, h, d, w, y.").
+	minBlockEndTime := model.TimeOrDuration(cmd.Flag("min-block-end-time", "Start of time range limit to serve. Thanos Store serves only blocks, which have end time greater than this value. Option can be a constant time in RFC3339 format or time duration relative to current time, such as -1.5d or 2h45m. Valid duration units are ms, s, m, h, d, w, y.").
 		Default("0000-01-01T00:00:00Z"))
 
-	maxBlockEndTime := model.TimeOrDuration(cmd.Flag("--max-block-end-time", "End of time range limit to serve. Thanos Store serves only blocks, which have end time is less than this value. Option can be a constant time in RFC3339 format or time duration relative to current time, such as -1.5d or 2h45m. Valid duration units are ms, s, m, h, d, w, y.").
+	maxBlockEndTime := model.TimeOrDuration(cmd.Flag("max-block-end-time", "End of time range limit to serve. Thanos Store serves only blocks, which have end time is less than this value. Option can be a constant time in RFC3339 format or time duration relative to current time, such as -1.5d or 2h45m. Valid duration units are ms, s, m, h, d, w, y.").
 		Default("9999-12-31T23:59:59Z"))
 
 	m[name] = func(g *run.Group, logger log.Logger, reg *prometheus.Registry, tracer opentracing.Tracer, debugLogging bool) error {
@@ -70,7 +70,7 @@ func registerStore(m map[string]setupFunc, app *kingpin.Application, name string
 			return errors.Wrap(err, "new cluster peer")
 		}
 
-		// Sanity check Time limits
+		// Sanity check Time filters
 		switch {
 		case minBlockStartTime.PrometheusTimestamp() > maxBlockStartTime.PrometheusTimestamp():
 			return errors.Errorf("invalid argument: --min-block-start-time '%s' can't be greater than --max-block-start-time  '%s'", minBlockStartTime, maxBlockStartTime)

diff --git a/docs/components/store.md b/docs/components/store.md
@@ -140,7 +140,7 @@ Flags:
       --block-sync-concurrency=20
                                  Number of goroutines to use when syncing blocks
                                  from object storage.
-      ----min-block-start-time=0000-01-01T00:00:00Z
+      --min-block-start-time=0000-01-01T00:00:00Z
                                  Start of time range limit to serve. Thanos
                                  Store serves only blocks, which have start time
                                  greater than this value. Option can be a
@@ -156,15 +156,15 @@ Flags:
                                  relative to current time, such as -1.5d or
                                  2h45m. Valid duration units are ms, s, m, h, d,
                                  w, y.
-      ----min-block-end-time=0000-01-01T00:00:00Z
+      --min-block-end-time=0000-01-01T00:00:00Z
                                  Start of time range limit to serve. Thanos
                                  Store serves only blocks, which have end time
                                  greater than this value. Option can be a
                                  constant time in RFC3339 format or time
                                  duration relative to current time, such as
                                  -1.5d or 2h45m. Valid duration units are ms, s,
                                  m, h, d, w, y.
-      ----max-block-end-time=9999-12-31T23:59:59Z
+      --max-block-end-time=9999-12-31T23:59:59Z
                                  End of time range limit to serve. Thanos Store
                                  serves only blocks, which have end time is less
                                  than this value. Option can be a constant time