Skip to content

Commit

Permalink
Use index header to read labels
Browse files Browse the repository at this point in the history
Signed-off-by: Filip Petkovski <[email protected]>
  • Loading branch information
fpetkovski committed Aug 1, 2023
1 parent 2f659ad commit db076c8
Showing 1 changed file with 2 additions and 5 deletions.
7 changes: 2 additions & 5 deletions pkg/store/bucket.go
Original file line number Diff line number Diff line change
Expand Up @@ -1670,16 +1670,13 @@ func (s *BucketStore) LabelNames(ctx context.Context, req *storepb.LabelNamesReq
func (s *BucketStore) UpdateLabelNames() {
newSet := stringset.New()
for _, b := range s.blocks {
indexr := b.indexReader()
defer runutil.CloseWithLogOnErr(b.logger, indexr, "label names")

res, err := indexr.block.indexHeaderReader.LabelNames()
labelNames, err := b.indexHeaderReader.LabelNames()
if err != nil {
level.Warn(s.logger).Log("msg", "error getting label names", "block", b.meta.ULID, "err", err.Error())
s.updateLabelNamesSet(stringset.AllStrings())
return
}
for _, l := range res {
for _, l := range labelNames {
newSet.Insert(l)
}
}
Expand Down

0 comments on commit db076c8

Please sign in to comment.