Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'bucket verify' command should error if S3 bucket does not exist #261

Closed
mattbostock opened this issue Mar 28, 2018 · 2 comments · Fixed by #512
Closed

'bucket verify' command should error if S3 bucket does not exist #261

mattbostock opened this issue Mar 28, 2018 · 2 comments · Fixed by #512
Labels
bug difficulty: easy good first issue

Comments

@mattbostock
Copy link
Contributor

mattbostock commented Mar 28, 2018 •
edited
Loading

Testing with Thanos at 94e26c6 on master against Ceph RADOS gateway (S3-like API), the 'bucket verify' command does not error if the specified bucket does not exist.
@bwplotka bwplotka added the bug label Apr 6, 2018
@darkdefender27
Copy link

darkdefender27 commented Jun 10, 2018 •
edited
Loading

@Bplotka I'd like to pick this up.

@darkdefender27
Copy link

Do we need to MakeBucket if it does not exists? or error out?

@jojohappy jojohappy mentioned this issue Sep 12, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug difficulty: easy good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed catch the error when failed to list objects for s3 jojohappy/thanos
3 participants
@mattbostock @darkdefender27 @bwplotka