Fixed catch the error when failed to list objects for s3 #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jojohappy <[email protected]>
bwplotka
approved these changes
Sep 12, 2018
pkg/objstore/s3/s3.go
Outdated
| @@ -196,6 +196,10 @@ func (b *Bucket) Iter(ctx context.Context, dir string, f func(string) error) err | |||
| } | |||
|
|
|||
| for object := range b.client.ListObjects(b.bucket, dir, false, ctx.Done()) { | |||
| // catch the error when failed to list objects | |||
There was a problem hiding this comment.
Can you make those comment full sentence (and below?) - upper case first letter and trailing period.
bwplotka
approved these changes
Sep 13, 2018
jojohappy
deleted the
fix_throw_errors_when_s3_bucket_does_not_exists
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: jojohappy [email protected]
Changes
Fixed #261
Verification
Just use a bucket that does not exist to execute
thanos bucket ls.