Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky QueryFrontend Unit Test #3084

Closed
squat opened this issue Aug 27, 2020 · 2 comments · Fixed by #3110
Closed

Flaky QueryFrontend Unit Test #3084

squat opened this issue Aug 27, 2020 · 2 comments · Fixed by #3110
Assignees
@yeya24
Labels
component: query-frontend

Comments

@squat
Copy link
Member

squat commented Aug 27, 2020 

--- FAIL: TestRoundTripSplitIntervalMiddleware (0.00s)
    --- FAIL: TestRoundTripSplitIntervalMiddleware/split_to_2_requests (0.00s)
        roundtrip_test.go:269: roundtrip_test.go:269:
            
            	exp: 2
            
            	got: 1
            
            
FAIL
FAIL	github.com/thanos-io/thanos/pkg/queryfrontend	0.037s
@yeya24
Copy link
Contributor

yeya24 commented Aug 31, 2020

I will take this. Thanks the issue!

@yeya24 yeya24 self-assigned this Aug 31, 2020
@yeya24 yeya24 mentioned this issue Aug 31, 2020
Merged
1 task
@kakkoyun kakkoyun mentioned this issue Aug 31, 2020
Merged
2 tasks
@kakkoyun
Copy link
Member

kakkoyun commented Sep 1, 2020

@yeya24 Is there anything that I can help with this?

@yeya24 yeya24 mentioned this issue Sep 1, 2020
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yeya24 yeya24

Labels
component: query-frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix flaky query frontend split interval unit test yeya24/thanos
3 participants
@kakkoyun @squat @yeya24