Fix flaky query frontend split interval unit test #3110
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ben Ye [email protected]
Changes
Fix #3084
In the previous test case, I used
counter
to mock HTTP handler and check how many times the handler is being called.But this mock handler doesn't return a meaningful result to query frontend so it might cause other requests canceled at the same time, which causes the flaky. https://github.com/cortexproject/cortex/blob/master/pkg/querier/queryrange/limits.go#L104
So if we return promql response which is valid for query frontend, then the test case should work.
Verification
Used the function below to test it works as expected.