Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI/CD: flaky tests #3641

Closed
yashrsharma44 opened this issue Dec 18, 2020 · 2 comments
Closed

CI/CD: flaky tests #3641

yashrsharma44 opened this issue Dec 18, 2020 · 2 comments

Comments

@yashrsharma44
Copy link
Contributor

While running GitHub Action tests for any Pull Request changes, the receiver tests somehow fail irrespective of the codechange made(or documentation changes). Seems like an example of a flaky test -
For Example - Flaky test observed in this #3630

FAIL
FAIL	github.com/thanos-io/thanos/test/e2e	111.932s
?   	github.com/thanos-io/thanos/test/e2e/e2ethanos	[no test files]
FAIL
make: *** [test-e2e] Error 1
Error: Makefile:234: recipe for target 'test-e2e' failed
Error: Process completed with exit code 2.
@yashrsharma44 yashrsharma44 changed the title flaky tests for receiver flaky tests Dec 18, 2020
@yashrsharma44 yashrsharma44 changed the title flaky tests CI/CD: flaky tests Dec 18, 2020
@bwplotka
Copy link
Member

bwplotka commented Feb 5, 2021 •
edited
Loading

Thanks, but this is too broad. Let's focus on a particular test which is flaky.

@onprem
Copy link
Member

onprem commented Feb 18, 2021 •
edited
Loading

I agree with Bartek. The specific case you are pointing to already has issue #2622 that is already closed (by #3798), so I am closing this issue for now as I think we don't have anything actionable here now. Let's reopen it if that's not the case.

@onprem onprem closed this as completed Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bwplotka @onprem @yashrsharma44