-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci/test: Flaky reloader test. #2622
Comments
Was I? :) I was touching the rule test, not reloader one. https://github.com/thanos-io/thanos/blob/master/pkg/reloader/reloader_test.go#L167 If you think it's related to my changes, I can have a look, but did not touch that test specifically. |
Ack, no worries, just yolo ping |
Hello 👋 Looks like there was no activity on this issue for last 30 days. |
Has anyone been able to replicate this anywhere other than circle? |
Not really - it's just slow CI. Looking on this now |
The problem is that's it's time based:
|
Fixed #2874 |
Re-opening this issue again. Reloader test become flaky again. |
Hello 👋 Looks like there was no activity on this issue for the last two months. |
Valid and flaky still.
Kind Regards,
Bartek Płotka (@bwplotka)
…On Sat, 7 Nov 2020 at 06:04, stale[bot] ***@***.***> wrote:
Hello 👋 Looks like there was no activity on this issue for the last two
months.
*Do you mind updating us on the status?* Is this still reproducible or
needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be
closed (we can always reopen an issue if we need!). Alternatively, use
remind command <https://probot.github.io/apps/reminders/> if you wish to
be reminded at some point in future.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#2622 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABVA3O2TCFR3P5SAAG3VJOTSOTIPHANCNFSM4ND7M5QA>
.
|
Hello 👋 Looks like there was no activity on this issue for the last two months. |
Closing for now as promised, let us know if you need this to be reopened! 🤗 |
Let's get into this (: It's still causing problems: #3773 |
https://circleci.com/gh/thanos-io/thanos/9139?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link
I remember @lilic was touching this test lately, so you mavbe you have idea? I did not check closer yet (:
The text was updated successfully, but these errors were encountered: