Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Compator page image is broken; add data about web viewer #3954

Closed
bwplotka opened this issue Mar 23, 2021 · 9 comments
Closed

docs: Compator page image is broken; add data about web viewer #3954

bwplotka opened this issue Mar 23, 2021 · 9 comments

Comments

@bwplotka
Copy link
Member

bwplotka commented Mar 23, 2021

  1. The image is not resized properly and goes outside of the column. (:

(https://thanos.io/tip/components/compact.md/)
image

  1. Compactor exposes /loaded and /global endpoints on HTTP port which gives amazing block UI explained here. Would be nice to add this information 🤗
@ravjotsandhu
Copy link

Sir would please give a little more context as to what to do? As far I understood this current image is to be replaced with that blocKUI one. Am I right?

@stale
Copy link

stale bot commented Jun 6, 2021

Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

@stale stale bot added the stale label Jun 6, 2021
@ravjotsandhu
Copy link

Yup I'm gonna try it out. Previously was infected with covid, right now viva and evaluations are going on. Would give it a shot soon

@stale stale bot removed the stale label Jun 7, 2021
sandeeppainuly added a commit to sandeeppainuly/thanos that referenced this issue Jun 21, 2021
sandeeppainuly added a commit to sandeeppainuly/thanos that referenced this issue Jun 21, 2021
sandeeppainuly added a commit to sandeeppainuly/thanos that referenced this issue Jun 21, 2021
GiedriusS pushed a commit that referenced this issue Jun 21, 2021
* issue #3954 - resolves compactor broken page image

Signed-off-by: Itaachime <[email protected]>

* issue #3954 - resolves compactor broken page image

Signed-off-by: Itaachime <[email protected]>

* issue #3954 - resolves compactor broken page image

Signed-off-by: Itaachime <[email protected]>
@GiedriusS
Copy link
Member

Closed via #4361

@GiedriusS
Copy link
Member

Oh, sorry, the 2nd point is not done yet. Help welcome 🤗

@GiedriusS GiedriusS reopened this Jun 21, 2021
@sandeeppainuly
Copy link
Contributor

@GiedriusS Can u please elaborate what is the requirement of second point because it is not clear to me

@bill3tt
Copy link
Contributor

bill3tt commented Jul 1, 2021

@sandeep1785

Compactor exposes /loaded and /global endpoints on HTTP port which gives amazing block UI explained here. Would be nice to add this information

I would interpret that as a request to add the information about the exposed by /loaded and /global endpoints to the compactor UI documentation 👍

edit: apologies, I didn't read the original issue thoroughly enough

bwplotka pushed a commit that referenced this issue Jul 5, 2021
* issue #3954 - resolves compactor broken page image

Signed-off-by: Itaachime <[email protected]>

* issue #3954 - resolves compactor broken page image

Signed-off-by: Itaachime <[email protected]>

* issue #3954 - resolves compactor broken page image

Signed-off-by: Itaachime <[email protected]>

* issue #4395 - added Adopters list to readme.md

Signed-off-by: Itaachime <[email protected]>

* issue #4395 - added Adopters list to readme.md

Signed-off-by: Itaachime <[email protected]>
@stale
Copy link

stale bot commented Sep 4, 2021

Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

@stale stale bot added the stale label Sep 4, 2021
@stale
Copy link

stale bot commented Sep 19, 2021

Closing for now as promised, let us know if you need this to be reopened! 🤗

@stale stale bot closed this as completed Sep 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants