querier: Moved query range API to middlewares reusing Cortex cache. #1039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bartek Plotka <[email protected]>
bwplotka
commented
Apr 16, 2019
| @@ -1,21 +1,26 @@ | |||
| module github.com/improbable-eng/thanos | |||
|
|
|||
| replace github.com/cortexproject/cortex => github.com/bwplotka/cortex v0.0.0-20190416102825-ae4098d14a9c | |||
There was a problem hiding this comment.
Tmp as per: cortexproject/cortex#1332
bwplotka
commented
Apr 16, 2019
| storeAPI storepb.StoreServer | ||
| } | ||
|
|
||
| func NewAPI(engine *promql.Engine, replicaLabel string, storeAPI storepb.StoreServer) *API { |
There was a problem hiding this comment.
I think I will factor this out to just use PromQL natively in api.go and new middlewares.
|
@bwplotka why did you close? Do you intend to continue working on this in a separate branch/PR? This could be a nice starting point for someone working on this. |
|
Sorry for not commenting when closing. I will respond on the issue: #1006 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very WIP
Signed-off-by: Bartek Plotka [email protected]