Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved CI to build Thanos with golang 1.12.5 #1156

Merged
merged 1 commit into from
May 17, 2019
Merged

Moved CI to build Thanos with golang 1.12.5 #1156

merged 1 commit into from
May 17, 2019

Conversation

bwplotka
Copy link
Member

This is to mitigate potential memory allocation latency bugs: prometheus/prometheus#5524

Signed-off-by: Bartek Plotka [email protected]

@bwplotka
Copy link
Member Author

cc @sylr

Copy link
Member

@GiedriusS GiedriusS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably update Dockerfile.multi-stage as well and the changelog but otherwise LGTM 🎉

@sylr
Copy link
Contributor

sylr commented May 17, 2019

Is it really needed ? I suppose by now all Go1.12 images already include 1.12.5. I think we just need to rebuild.

@bwplotka
Copy link
Member Author

Can we confirm that is the case?

Also I would be 10x more comfortable if we would pin to single version. Otherwise we have 0 record and control of what the Golang version was when building image. That's unacceptable IMO.

@brancz
Copy link
Member

brancz commented May 17, 2019

I’d prefer exact versions as well.

This is to mitigate potential memory allocation latency bugs: prometheus/prometheus#5524

Signed-off-by: Bartek Plotka <[email protected]>

# Conflicts:
#	CHANGELOG.md
@brancz brancz merged commit 6a72b1d into master May 17, 2019
@brancz brancz deleted the go1.12.5 branch May 17, 2019 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants