Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

promclient: drop version check #1163

Merged
merged 2 commits into from
May 27, 2019
Merged

promclient: drop version check #1163

merged 2 commits into from
May 27, 2019

Commits on May 21, 2019

  1. promclient: drop version check 

    The version check would check the prometheus version and if > 2.2.0
would query the flags endpoint to do some extra validation.

Remove this for just checking the flags endpoints and if it responds do
the validation; otherwise log the failure, but continue the startup.

Signed-off-by: Miek Gieben <[email protected]>
    @miekg
    miekg committed May 21, 2019
    Configuration menu
    Copy the full SHA
    0ad5fd0 View commit details
    Browse the repository at this point in the history

  2. address nits from review 

    Signed-off-by: Miek Gieben <[email protected]>
    @miekg
    miekg committed May 21, 2019
    Configuration menu
    Copy the full SHA
    c01cff8 View commit details
    Browse the repository at this point in the history