-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support max source resolution for instant queries #1431
Support max source resolution for instant queries #1431
Commits on Aug 27, 2019
-
support max_source_resolution param for instant queries
This adds support for the ?max_source_resolution query param for instant queries. Instant queries had the issue that when there was a subquery requesting wide data ranges e.g. sum_over_time(metric_name[30d])) and the retention of raw data was for example only 7d, the query would (silently) only take data from the last 7 days into account (ignoring the downsampled 5m and 1h timeseries that were available with longer retention). We default to 1h max_source_resolution for now as this will cover the highest/broadest resolution available and should include all retention. It is configurable per query (although no known clients send it). Signed-off-by: Tim Reddehase <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for eb5ee6b - Browse repository at this point
Copy the full SHA eb5ee6bView commit details -
add flag for defaultMaxSourceResolution
The flag only affects instant queries. Signed-off-by: Tim Reddehase <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 2f0322c - Browse repository at this point
Copy the full SHA 2f0322cView commit details -
update docs (forgot the make docs).
Signed-off-by: Tim Reddehase <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 9cf0be5 - Browse repository at this point
Copy the full SHA 9cf0be5View commit details -
use step/5 directly within query_range
Instead of defining an additional function we do the adjustment of maxSourceResolution directly in query_range. Signed-off-by: Tim Reddehase <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for adb02ed - Browse repository at this point
Copy the full SHA adb02edView commit details -
add instant-query flag example case documentation.
Signed-off-by: Tim Reddehase <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 82338ae - Browse repository at this point
Copy the full SHA 82338aeView commit details -
adjust naming & comments to review comments.
Signed-off-by: Tim Reddehase <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 298a929 - Browse repository at this point
Copy the full SHA 298a929View commit details -
hide --query.instant.default.max_source_resolution.
Signed-off-by: Tim Reddehase <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 4dc1856 - Browse repository at this point
Copy the full SHA 4dc1856View commit details -
remove hidden instant-query resolution flag from docs.
Signed-off-by: Tim Reddehase <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 2433524 - Browse repository at this point
Copy the full SHA 2433524View commit details