Support max source resolution for instant queries #1431
Merged
Commits on Aug 27, 2019
-
support max_source_resolution param for instant queries
This adds support for the ?max_source_resolution query param for instant queries. Instant queries had the issue that when there was a subquery requesting wide data ranges e.g. sum_over_time(metric_name[30d])) and the retention of raw data was for example only 7d, the query would (silently) only take data from the last 7 days into account (ignoring the downsampled 5m and 1h timeseries that were available with longer retention). We default to 1h max_source_resolution for now as this will cover the highest/broadest resolution available and should include all retention. It is configurable per query (although no known clients send it). Signed-off-by: Tim Reddehase <[email protected]>
-
add flag for defaultMaxSourceResolution
The flag only affects instant queries. Signed-off-by: Tim Reddehase <[email protected]>
-
update docs (forgot the make docs).
Signed-off-by: Tim Reddehase <[email protected]>
-
use step/5 directly within query_range
Instead of defining an additional function we do the adjustment of maxSourceResolution directly in query_range. Signed-off-by: Tim Reddehase <[email protected]>
-
add instant-query flag example case documentation.
Signed-off-by: Tim Reddehase <[email protected]>
-
adjust naming & comments to review comments.
Signed-off-by: Tim Reddehase <[email protected]>
-
hide --query.instant.default.max_source_resolution.
Signed-off-by: Tim Reddehase <[email protected]>
-
remove hidden instant-query resolution flag from docs.
Signed-off-by: Tim Reddehase <[email protected]>
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.