Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rule: Fixed wrong query url in rules and alerts pages #1488

Merged
merged 1 commit into from
Sep 4, 2019

Conversation

jojohappy
Copy link
Member

Signed-off-by: jojohappy [email protected]

  • [] CHANGELOG entry if change is relevant to the end user.

Changes

[Bugfix]: User can not click the link of expr or alert to jump to Query ui in rule pages.

Verification

Visit the rule or alert page, and try to click the link of expr or alert.

@FUSAKLA
Copy link
Member

FUSAKLA commented Sep 3, 2019

Yes! 🎉
Thank you! I always forgot to fix it but it always irritated me 😄

Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tested it? (:

Looks legit to me! LGTM.

@bwplotka bwplotka merged commit e8bf6f5 into thanos-io:master Sep 4, 2019
@jojohappy
Copy link
Member Author

Have you tested it?

Yes, it has been already run in my environment.

@jojohappy jojohappy deleted the fix_rule_query_url branch September 4, 2019 08:03
wbh1 pushed a commit to wbh1/thanos that referenced this pull request Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants