Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new prometheus.ready_timeout CLI option to the sidecar #1660

Merged
merged 1 commit into from
Oct 18, 2019

Conversation

bandesz
Copy link
Contributor

@bandesz bandesz commented Oct 17, 2019

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

The current timeout while the Prometheus instance is starting up is a constant 10 minutes.
As reading the WAL can take a long time we would like to set a custom timeout value, so the Thanos sidecar container is not erroring out every 10 minutes.

Verification

I ran make test with the in-memory store tests.

@bandesz bandesz force-pushed the prometheus_ready_timeout_opt branch 2 times, most recently from 6b3685b to 0be3bf8 Compare October 17, 2019 12:26
Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make, sense! 👍 Thanks!

@bwplotka
Copy link
Member

Can you sign the commit as DCO bot suggests? (:

The current timeout while the Prometheus instance is starting up is a constant 10 minutes.
As reading the WAL can take a long time we would like to set a custom timeout value, so the Thanos
sidecar container is not erroring out every 10 minutes.

Signed-off-by: Andras Ferencz-Szabo <[email protected]>
@bandesz bandesz force-pushed the prometheus_ready_timeout_opt branch from 0be3bf8 to fa1e935 Compare October 17, 2019 18:43
@bandesz
Copy link
Contributor Author

bandesz commented Oct 17, 2019

@bwplotka sure, done!

@bwplotka bwplotka merged commit f0d3b14 into thanos-io:master Oct 18, 2019
GiedriusS pushed a commit that referenced this pull request Oct 28, 2019
The current timeout while the Prometheus instance is starting up is a constant 10 minutes.
As reading the WAL can take a long time we would like to set a custom timeout value, so the Thanos
sidecar container is not erroring out every 10 minutes.

Signed-off-by: Andras Ferencz-Szabo <[email protected]>
Signed-off-by: Giedrius Statkevičius <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants